Test fixes #618
Open
Test fixes #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set DEPENDENCIES_MPIDE_DIR to the the newest directory in DEPENDENCIES_DIR matching mpide-0023-*
Build is failing because pyserial 3.0.1 is already installed and can't be uninstalled. Instead, add --ignore-installed flag to pip command so that pyserial 2.7 will be installed without the need to uninstall 3.0.1.
Add DEPENDENCIES_FOLDER path to ARDUINO_FILE missing in subshell. Also add additional debug output viewable in CI log.
|
Thanks for the PR. What are your thoughts? I like the |
|
no idea @sudar, travis seems to break more often than its worth, so anything that attempts to fix it is great! |
|
what about moving to github actions? they offer much more than travis, are free and you can also run macOS to test this platform, not just linux. |
|
I manually cherry picked merged the runtest.sh niceties. I'd already made changes to get the tests running again so merging this PR would have been more work - I think that's why conflicts are showing. So the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to test scripts:
bootstrap.sh
runtests.sh
Common.mk